-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added optional args and kwargs arguments to on_success and on_failure #55
Added optional args and kwargs arguments to on_success and on_failure #55
Conversation
…ditionally added typehinting for both functions and the new kwargs and args arguments in RustSocket.connect()
Updated per request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure whether to bundle the on_failure into the tuple as well... What do you think? as long as it is type hinted properly it should be fine
I don't think that should change. Keeping args and functions themselves separate makes it simple to understand and whoever needs args will find it anyway. I'm not home right now so ill make the changes later/tomorrow. |
I also added typehinting for both functions and the new kwargs and args arguments in RustSocket.connect()
My test code